From eb4a1ec781c9d3f9801f7a2925b11ca696cc205c Mon Sep 17 00:00:00 2001 From: resonantsky Date: Mon, 23 Mar 2026 16:37:50 +0200 Subject: [PATCH] lint: fix ruff and pylint warnings in rocm_ext and rocm_mgr --- scripts/rocm/rocm_mgr.py | 4 ++-- scripts/rocm_ext.py | 13 ++++++++----- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/scripts/rocm/rocm_mgr.py b/scripts/rocm/rocm_mgr.py index f517a7452..a8eeb665e 100644 --- a/scripts/rocm/rocm_mgr.py +++ b/scripts/rocm/rocm_mgr.py @@ -1,12 +1,12 @@ import os import sys from pathlib import Path -from typing import Dict, Any, Optional +from typing import Dict, Optional import installer from modules.logger import log from modules.json_helpers import readfile, writefile -from scripts.rocm.rocm_vars import ROCM_ENV_VARS, SOLVER_GROUPS, SOLVER_DISABLED_BY_DEFAULT # pylint: disable=no-name-in-module +from scripts.rocm.rocm_vars import ROCM_ENV_VARS # pylint: disable=no-name-in-module from scripts.rocm import rocm_profiles # pylint: disable=no-name-in-module diff --git a/scripts/rocm_ext.py b/scripts/rocm_ext.py index 6cd664fbf..6e86bdecc 100644 --- a/scripts/rocm_ext.py +++ b/scripts/rocm_ext.py @@ -2,6 +2,9 @@ import gradio as gr import installer from modules import scripts_manager, shared +# rocm_mgr exposes package-internal helpers (prefixed _) that are intentionally called here +# pylint: disable=protected-access + class Script(scripts_manager.Script): def title(self): @@ -73,7 +76,7 @@ class Script(scripts_manager.Script): btn_rdna4 = gr.Button("RDNA4 (RX 9000)", elem_id="rocm_btn_rdna4") style_out = gr.HTML("") info_out = gr.HTML(value=_info_html, elem_id="rocm_info_table") - + # General vars (dropdowns, textboxes, checkboxes) with gr.Group(): gr.HTML("

MIOpen Settings

") @@ -92,7 +95,7 @@ class Script(scripts_manager.Script): var_names.append(name) components.append(comp) gr.HTML("
📄 MIOpen Environment Variables Reference

") - + def _autosave_field(name, value): meta = rocm_vars.ROCM_ENV_VARS[name] stored = rocm_mgr._dropdown_stored(str(value), meta["options"]) @@ -114,7 +117,7 @@ class Script(scripts_manager.Script): meta = rocm_vars.ROCM_ENV_VARS[name] val = saved.get(name, meta["default"]) if meta["widget"] == "checkbox": - result.append(gr.update(value=(val == "1"))) + result.append(gr.update(value=val == "1")) elif meta["widget"] == "dropdown": result.append(gr.update(value=rocm_mgr._dropdown_display(val, meta["options"]))) else: @@ -138,7 +141,7 @@ class Script(scripts_manager.Script): meta = rocm_vars.ROCM_ENV_VARS[name] val = updated.get(name, meta["default"]) if meta["widget"] == "checkbox": - result.append(gr.update(value=(val == "1"))) + result.append(gr.update(value=val == "1")) elif meta["widget"] == "dropdown": result.append(gr.update(value=rocm_mgr._dropdown_display(val, meta["options"]))) else: @@ -181,7 +184,7 @@ class Script(scripts_manager.Script): meta = rocm_vars.ROCM_ENV_VARS[pname] val = updated.get(pname, meta["default"]) if meta["widget"] == "checkbox": - result.append(gr.update(value=(val == "1"))) + result.append(gr.update(value=val == "1")) elif meta["widget"] == "dropdown": result.append(gr.update(value=rocm_mgr._dropdown_display(val, meta["options"]))) else: