Public/koboldcpp
1
0
Fork 0
mirror of https://github.com/LostRuins/koboldcpp.git synced 2026-09-19 01:05:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed gemma4v image crashing on encode, however images are not yet working correctly

Browse Source
This commit is contained in:
Concedo
2026-04-03 15:56:35 +08:00
parent 17678748ac
commit e8cffa37c8
4 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/mtmd/llava.cpp
+11 -1
View File
@@ -78,7 +78,17 @@ bool llava_image_embed_make_with_clip_img(clip_ctx * ctx_clip, int n_threads, co
max_ny = std::max(max_ny,b);
}
image_embd = (float *)malloc(clip_embd_nbytes_by_img(ctx_clip, max_nx, max_ny));
} else {
}
else if(clip_is_gemma4(ctx_clip)) //gemma4 vision
{
const size_t n_imgs = clip_image_f32_batch_n_images(preprocessed_img.get());
clip_image_f32 * img_res = clip_image_f32_get_img(preprocessed_img.get(), 0);
int n_img_pos = clip_n_output_tokens(ctx_clip, img_res);
int nbytes = n_img_pos * clip_n_mmproj_embd(ctx_clip) * sizeof(float);
image_embd = (float *)malloc(nbytes);
}
else
{
image_embd = (float *)malloc(clip_embd_nbytes(ctx_clip)*num_max_patches); // TODO: base on gridsize/llava model
}
if (!image_embd) {