diff --git a/common/arg.cpp b/common/arg.cpp index 210b3e8c0..5debdea7e 100644 --- a/common/arg.cpp +++ b/common/arg.cpp @@ -2586,7 +2586,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex {"-hf", "-hfr", "--hf-repo"}, "/[:quant]", "Hugging Face model repository; quant is optional, case-insensitive, default to Q4_K_M, or falls back to the first file in the repo if Q4_K_M doesn't exist.\n" "mmproj is also downloaded automatically if available. to disable, add --no-mmproj\n" - "example: unsloth/phi-4-GGUF:q4_k_m\n" + "example: ggml-org/GLM-4.7-Flash-GGUF:Q4_K_M\n" "(default: unused)", [](common_params & params, const std::string & value) { params.model.hf_repo = value; diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index 8cfd0bf2f..dba190b48 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -31,10 +31,10 @@ import gguf from gguf.vocab import MistralTokenizerType, MistralVocab try: - from mistral_common.tokens.tokenizers.base import TokenizerVersion # pyright: ignore[reportMissingImports] - from mistral_common.tokens.tokenizers.multimodal import DATASET_MEAN as _MISTRAL_COMMON_DATASET_MEAN, DATASET_STD as _MISTRAL_COMMON_DATASET_STD # pyright: ignore[reportMissingImports] - from mistral_common.tokens.tokenizers.tekken import Tekkenizer # pyright: ignore[reportMissingImports] - from mistral_common.tokens.tokenizers.sentencepiece import ( # pyright: ignore[reportMissingImports] + from mistral_common.tokens.tokenizers.base import TokenizerVersion # type: ignore[import-not-found] + from mistral_common.tokens.tokenizers.multimodal import DATASET_MEAN as _MISTRAL_COMMON_DATASET_MEAN, DATASET_STD as _MISTRAL_COMMON_DATASET_STD # type: ignore[import-not-found] + from mistral_common.tokens.tokenizers.tekken import Tekkenizer # type: ignore[import-not-found] + from mistral_common.tokens.tokenizers.sentencepiece import ( # type: ignore[import-not-found] SentencePieceTokenizer, ) @@ -45,9 +45,9 @@ except ImportError: _MISTRAL_COMMON_DATASET_STD = (0.26862954, 0.26130258, 0.27577711) _mistral_common_installed = False - TokenizerVersion = None - Tekkenizer = None - SentencePieceTokenizer = None + TokenizerVersion: Any = None + Tekkenizer: Any = None + SentencePieceTokenizer: Any = None _mistral_import_error_msg = ( "Mistral format requires `mistral-common` to be installed. Please run " "`pip install mistral-common[image,audio]` to install it." @@ -145,6 +145,7 @@ class ModelBase: self.model_name = model_name self.dir_model_card = dir_model # overridden in convert_lora_to_gguf.py self._is_nvfp4 = False + self._is_mxfp4 = False # Apply heuristics to figure out typical tensor encoding based on first tensor's dtype # NOTE: can't use field "torch_dtype" in config.json, because some finetunes lie. @@ -220,7 +221,7 @@ class ModelBase: if weight_map is None or not isinstance(weight_map, dict): raise ValueError(f"Can't load 'weight_map' from {index_name!r}") tensor_names_from_index.update(weight_map.keys()) - part_dict: dict[str, None] = dict.fromkeys(weight_map.values(), None) + part_dict: dict[str, None] = dict.fromkeys(weight_map.values(), None) # ty: ignore[invalid-assignment] part_names = sorted(part_dict.keys()) else: weight_map = {} @@ -712,6 +713,7 @@ class ModelBase: def prepare_tensors(self): # detect NVFP4 quantization (ModelOpt format) quant_algo = (self.hparams.get("quantization_config") or {}).get("quant_algo") + quant_method = (self.hparams.get("quantization_config") or {}).get("quant_method") quant_layers = (self.hparams.get("quantization_config") or {}).get("quantized_layers") or {} quant_config_file = self.dir_model / "hf_quant_config.json" @@ -728,6 +730,7 @@ class ModelBase: quant_algo = "NVFP4" self._is_nvfp4 = quant_algo == "NVFP4" + self._is_mxfp4 = quant_method == "mxfp4" # NVFP4 weights are repacked and written directly to gguf_writer. # This must run before dequant_model so NVFP4 tensors are removed @@ -876,6 +879,12 @@ class ModelBase: if self.metadata.name is None: self.metadata.name = self.dir_model.name + if self.ftype in (gguf.LlamaFileType.ALL_F32, gguf.LlamaFileType.MOSTLY_F16, gguf.LlamaFileType.MOSTLY_BF16): + if self._is_nvfp4: + self.ftype = gguf.LlamaFileType.MOSTLY_NVFP4 + elif self._is_mxfp4: + self.ftype = gguf.LlamaFileType.MOSTLY_MXFP4_MOE + # Generate parameter weight class (useful for leader boards) if not yet determined if self.metadata.size_label is None and total_params > 0: self.metadata.size_label = gguf.size_label(total_params, shared_params, expert_params, expert_count) @@ -5882,7 +5891,7 @@ class InternLM2Model(TextModel): logger.error(f'Error: Missing {tokenizer_path}') sys.exit(1) - sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] + sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] # ty: ignore[unresolved-attribute] sentencepiece_model.ParseFromString(open(tokenizer_path, "rb").read()) add_prefix = sentencepiece_model.normalizer_spec.add_dummy_prefix @@ -6203,7 +6212,7 @@ class BertModel(TextModel): vocab_size = max(self.hparams.get("vocab_size", 0), tokenizer.vocab_size) else: - sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] + sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] # ty: ignore[unresolved-attribute] sentencepiece_model.ParseFromString(open(tokenizer_path, "rb").read()) assert sentencepiece_model.trainer_spec.model_type == 1 # UNIGRAM @@ -8880,7 +8889,7 @@ class T5Model(TextModel): if not tokenizer_path.is_file(): raise FileNotFoundError(f"File not found: {tokenizer_path}") - sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] + sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] # ty: ignore[unresolved-attribute] sentencepiece_model.ParseFromString(open(tokenizer_path, "rb").read()) # some models like Pile-T5 family use BPE tokenizer instead of Unigram @@ -9017,7 +9026,7 @@ class T5EncoderModel(TextModel): if not tokenizer_path.is_file(): raise FileNotFoundError(f"File not found: {tokenizer_path}") - sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] + sentencepiece_model = model.ModelProto() # pyright: ignore[reportAttributeAccessIssue] # ty: ignore[unresolved-attribute] sentencepiece_model.ParseFromString(open(tokenizer_path, "rb").read()) # some models like Pile-T5 family use BPE tokenizer instead of Unigram @@ -11125,8 +11134,7 @@ class GptOssModel(TextModel): # TODO: remove once MXFP4 is supported more generally def dequant_model(self): - quant_config = self.hparams.get("quantization_config") - if quant_config is not None and quant_config.get("quant_method") == "mxfp4": + if self._is_mxfp4: return return super().dequant_model() @@ -12279,6 +12287,7 @@ class LazyTorchTensor(gguf.LazyBase): kwargs = {} if func is torch.Tensor.numpy: + assert len(args) return args[0].numpy() return cls._wrap_fn(func)(*args, **kwargs) diff --git a/convert_llama_ggml_to_gguf.py b/convert_llama_ggml_to_gguf.py index 29b14e98d..52827e669 100755 --- a/convert_llama_ggml_to_gguf.py +++ b/convert_llama_ggml_to_gguf.py @@ -112,11 +112,11 @@ class Tensor: (n_dims, name_len, dtype) = struct.unpack('<3I', data[offset:offset + 12]) assert n_dims >= 0 and n_dims <= 4, f'Invalid tensor dimensions {n_dims}' assert name_len < 4096, 'Absurd tensor name length' - quant = gguf.GGML_QUANT_SIZES.get(dtype) + self.dtype = gguf.GGMLQuantizationType(dtype) + quant = gguf.GGML_QUANT_SIZES.get(self.dtype) assert quant is not None, 'Unknown tensor type' (blksize, tysize) = quant offset += 12 - self.dtype= gguf.GGMLQuantizationType(dtype) self.dims = struct.unpack(f'<{n_dims}I', data[offset:offset + (4 * n_dims)]) offset += 4 * n_dims self.name = bytes(data[offset:offset + name_len]) diff --git a/convert_lora_to_gguf.py b/convert_lora_to_gguf.py index 871ce8242..ee98d0cf9 100755 --- a/convert_lora_to_gguf.py +++ b/convert_lora_to_gguf.py @@ -199,10 +199,13 @@ class LoraTorchTensor: kwargs = {} if func is torch.permute: + assert len(args) return type(args[0]).permute(*args, **kwargs) elif func is torch.reshape: + assert len(args) return type(args[0]).reshape(*args, **kwargs) elif func is torch.stack: + assert len(args) assert isinstance(args[0], Sequence) dim = kwargs.get("dim", 0) assert dim == 0 @@ -211,6 +214,7 @@ class LoraTorchTensor: torch.stack([b._lora_B for b in args[0]], dim), ) elif func is torch.cat: + assert len(args) assert isinstance(args[0], Sequence) dim = kwargs.get("dim", 0) assert dim == 0 @@ -362,7 +366,7 @@ if __name__ == '__main__': logger.error(f"Model {hparams['architectures'][0]} is not supported") sys.exit(1) - class LoraModel(model_class): + class LoraModel(model_class): # ty: ignore[unsupported-base] model_arch = model_class.model_arch lora_alpha: float diff --git a/embd_res/klite.embd b/embd_res/klite.embd index 6819924df..8ec914d27 100644 --- a/embd_res/klite.embd +++ b/embd_res/klite.embd @@ -12,7 +12,7 @@ Current version indicated by LITEVER below. -->