From 12c719b3f12fe55042669291e88da2d02ad20c70 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Sun, 22 Feb 2026 09:47:43 +0200 Subject: [PATCH] gguf-py : error on duplicate keys when reading --- gguf-py/gguf/gguf_reader.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gguf-py/gguf/gguf_reader.py b/gguf-py/gguf/gguf_reader.py index b2c3df9a84..1dd0898666 100644 --- a/gguf-py/gguf/gguf_reader.py +++ b/gguf-py/gguf/gguf_reader.py @@ -203,11 +203,11 @@ class GGUFReader: def _push_field(self, field: ReaderField, skip_sum: bool = False) -> int: if field.name in self.fields: - # TODO: add option to generate error on duplicate keys - # raise KeyError(f'Duplicate {field.name} already in list at offset {field.offset}') + # TODO: add option to make this a warning and accept duplicate keys like below + raise KeyError(f'Duplicate {field.name} already in list at offset {field.offset}') - logger.warning(f'Duplicate key {field.name} at offset {field.offset}') - self.fields[field.name + '_{}'.format(field.offset)] = field + #logger.warning(f'Duplicate key {field.name} at offset {field.offset}') + #self.fields[field.name + '_{}'.format(field.offset)] = field else: self.fields[field.name] = field return 0 if skip_sum else sum(int(part.nbytes) for part in field.parts)