From 3ab76b71ba56fcf093c09a0cf935f6c47b454d83 Mon Sep 17 00:00:00 2001 From: Aleksander Grygier Date: Fri, 4 Sep 2026 13:30:39 +0200 Subject: [PATCH] ui : trim verbose and stale comments Tighten the over-explained comments in the reasoning panel and models types, and drop a stale comment left behind by removed code in the details view. Assisted-by: llama-ui:Qwen3.8-Flash-Next --- .../ModelsSelectorReasoningPanel.svelte | 23 ++++++------------- .../ModelsDiscoverDetails.svelte | 3 --- tools/ui/src/lib/types/models.d.ts | 23 +++++-------------- 3 files changed, 13 insertions(+), 36 deletions(-) diff --git a/tools/ui/src/lib/components/app/models/ModelsSelector/ModelsSelectorReasoningPanel.svelte b/tools/ui/src/lib/components/app/models/ModelsSelector/ModelsSelectorReasoningPanel.svelte index c9aa7a3adb..2756e896dd 100644 --- a/tools/ui/src/lib/components/app/models/ModelsSelector/ModelsSelectorReasoningPanel.svelte +++ b/tools/ui/src/lib/components/app/models/ModelsSelector/ModelsSelectorReasoningPanel.svelte @@ -11,22 +11,17 @@ let expanded = $state(false); - + (expanded = open)} open={expanded}> - + {#snippet child({ props })} - + {#if reasoning.isReasoningActive} @@ -54,13 +49,9 @@ - + {#if expanded} - +
{#each reasoning.levels as level (level.value)} {@const tokenLabel = reasoning.tokenLabel(level)} diff --git a/tools/ui/src/lib/components/app/models/discover/ModelsDiscoverDetails/ModelsDiscoverDetails.svelte b/tools/ui/src/lib/components/app/models/discover/ModelsDiscoverDetails/ModelsDiscoverDetails.svelte index d9331089fe..d507e6674c 100644 --- a/tools/ui/src/lib/components/app/models/discover/ModelsDiscoverDetails/ModelsDiscoverDetails.svelte +++ b/tools/ui/src/lib/components/app/models/discover/ModelsDiscoverDetails/ModelsDiscoverDetails.svelte @@ -46,9 +46,6 @@ let hasTools = $derived(detectToolUseSupport(gguf?.chat_template ?? '')); let hasReasoning = $derived(detectThinkingSupport(gguf?.chat_template ?? '')); - // Draft sidecars (mtp, dflash, dspark, eagle3) present in the repo, e.g. - // speculative-decoding drafts. mmproj is excluded: it is vision. - let bitDepthRows = $derived.by(() => { const rows = new SvelteMap(); diff --git a/tools/ui/src/lib/types/models.d.ts b/tools/ui/src/lib/types/models.d.ts index 485c5b0aee..af740d1b09 100644 --- a/tools/ui/src/lib/types/models.d.ts +++ b/tools/ui/src/lib/types/models.d.ts @@ -26,33 +26,24 @@ export interface ModelOption { tags?: string[]; } -/** - * Ephemeral UI-only load progress for one model instance. - * Lives only while a load runs, driven by the /models/sse feed. - * stage is absent until the feed reports its first stage. - */ +/** UI-only load progress for one model, driven by the /models/sse feed. */ export interface ModelLoadProgress { stages: ApiModelLoadStage[]; current: ApiModelLoadStage; value: number; } -/** - * Per-byte download progress for one in-flight model download, driven by the - * /models/sse feed. Lives only while a download runs. - */ + +/** Per-file bytes of an in-flight download. */ export interface ModelDownloadFileProgress { - /** Bytes downloaded for this file so far. */ done: number; - /** Total bytes of the file. */ total: number; } +/** Progress of an in-flight download, summed across its files. */ export interface ModelDownloadProgress { - /** Summed progress across all files of the download plan. */ downloadedBytes: number; - /** Summed plan size across all files. */ totalBytes: number; - /** Per-file progress keyed by file URL, as reported by the feed. */ + /** Per-file progress keyed by file URL. */ files: Record; } @@ -68,9 +59,7 @@ export interface ParsedModelId { tags: string[]; } -/** - * Modality capabilities for file validation - */ +/** Modality capabilities for file validation. */ export interface ModalityCapabilities { hasVision: boolean; hasAudio: boolean;