Public/automatic
1
0
Fork 0
mirror of https://github.com/vladmandic/automatic synced 2026-09-20 01:31:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(lora): name the gate both channel mechanisms share

Browse Source 
Hosting asked select_candidate whether it could take a layer, and that
function reads the host rank, so each mechanism was gated through the
other one's name. The shared conditions move into channel_candidate,
which says what they actually test: the layer is quantized, a loaded
network covers it, and there is a rank budget to spend on it.
This commit is contained in:
CalamitousFelicitousness
2026-08-30 05:06:01 +01:00
parent 7de65eca16
commit 2ae31ce46f
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/lora/lora_sdnq.py
+8 -3
View File
@@ -259,8 +259,8 @@ def append_factors(self, ups, downs):
return segments, deq.use_quantized_matmul
def select_candidate(self, network_layer_name, wanted_names):
"""True when this layer can carry a set on the svd channel; select pairs ride it at any bit width."""
def channel_candidate(self, network_layer_name, wanted_names):
"""True when this layer can carry a set on the svd channel: quantized, covered, and given a rank to spend."""
if not enabled():
return False
if int(getattr(shared.opts, 'lora_sdnq_host_rank', 0) or 0) <= 0:
@@ -272,9 +272,14 @@ def select_candidate(self, network_layer_name, wanted_names):
return any(net.modules.get(network_layer_name, None) is not None for net in l.loaded_networks)
def select_candidate(self, network_layer_name, wanted_names):
"""True when a select pair can ride this layer's svd channel; pairs ride it at any bit width."""
return channel_candidate(self, network_layer_name, wanted_names)
def host_candidate(self, network_layer_name, wanted_names):
"""True when this layer's set should ride the svd channel as a truncated svd: non-factorable sets below 8 bits, dense-combined sets at any width."""
if not select_candidate(self, network_layer_name, wanted_names):
if not channel_candidate(self, network_layer_name, wanted_names):
return False
if lora_stack.mode() in lora_stack.DENSE_MODES and not network_layer_name.startswith('lora_te'):
if sum(1 for net in l.loaded_networks if net.modules.get(network_layer_name, None) is not None) >= 2: