Public/llama.cpp
1
0
Fork 0
mirror of https://github.com/ggml-org/llama.cpp.git synced 2026-09-19 17:24:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

ui: align preferences section headers with their methods

Browse Source 
The Reasoning Effort and Working Directory headers sat above tool
policy methods; move them above setCwd and setReasoningEffort. Also
clarify the disabled tools JSDoc: existing rows with an unset field
have an empty policy, defaults apply only when there is no active
conversation.

Assisted-by: pi
This commit is contained in:
Aleksander Grygier
2026-08-26 20:34:23 +02:00
committed by GitHub
parent 40d590623e
commit c7dd200b37
1 changed files with 26 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/ui/src/lib/stores/conversations/preferences.svelte.ts
+26 -18
View File
@@ -49,12 +49,20 @@ export interface ConversationsPreferencesHost {
applyConversationUpdate(id: string, updates: Partial<DatabaseConversation>): void;
}
/** Effective disabled tool keys: conversation row, falling back to defaults. */
/**
* Effective disabled tool keys: the active conversation row, or the global
* defaults when there is no conversation. An existing row with an unset
* field has an empty policy, not a fallback to defaults.
*/
function buildDisabledTools(conv: DatabaseConversation | null): Set<string> {
return new Set(conv ? (conv.disabledTools ?? []) : [...toolsStore.disabledTools]);
}
/** Effective disabled tool categories: conversation row, falling back to defaults. */
/**
* Effective disabled tool categories: the active conversation row, or the
* global defaults when there is no conversation. An existing row with an
* unset field has an empty policy, not a fallback to defaults.
*/
function buildDisabledToolCategories(conv: DatabaseConversation | null): Set<ToolSource> {
return new Set(
conv ? (conv.disabledToolCategories ?? []) : [...toolsStore.disabledToolCategories]
@@ -184,6 +192,14 @@ export class ConversationPreferences {
this.pendingCwd = null;
}
/**
*
*
* Working Directory
*
*
*/
/**
* Sets the working directory for the active conversation. Pass `null` or
* an empty string to clear it, which restores the picker's empty state.
@@ -217,6 +233,14 @@ export class ConversationPreferences {
this.pendingCwd = null;
}
/**
*
*
* Reasoning Effort
*
*
*/
/**
* Sets the reasoning effort for the active conversation.
* If no conversation exists, stores the global default.
@@ -268,14 +292,6 @@ export class ConversationPreferences {
await this.toggleTool(toolsStore.getMcpServerToolsKey(serverId));
}
/**
*
*
* Reasoning Effort
*
*
*/
async toggleTool(key: string): Promise<void> {
const conv: DatabaseConversation | null = this.host.activeConversation;
@@ -305,14 +321,6 @@ export class ConversationPreferences {
await DatabaseService.updateConversation(conv.id, { disabledToolCategories });
}
/**
*
*
* Working Directory
*
*
*/
private async persistDisabledTools(disabled: Set<string>): Promise<void> {
const conv = this.host.activeConversation;