ui : trim verbose and stale comments

Tighten the over-explained comments in the reasoning panel and models types,
and drop a stale comment left behind by removed code in the details view.

Assisted-by: llama-ui:Qwen3.8-Flash-Next
This commit is contained in:
Aleksander Grygier
2026-09-04 13:30:39 +02:00
parent 75d95fa41c
commit 3ab76b71ba
3 changed files with 13 additions and 36 deletions
@@ -11,22 +11,17 @@
let expanded = $state(false);
</script>
<!-- Reasoning effort picker for the models dropdown footer. Unlike
ChatFormActionAddReasoningSubmenu, which opens a flyout submenu, this one
expands in place: pinned to the bottom of a scrolling menu, a flyout would
float over the very list it belongs to. -->
<!-- Reasoning effort picker for the models dropdown footer; expands in place
(a flyout submenu would cover the list it belongs to). -->
<Collapsible.Root class="min-w-0" onOpenChange={(open) => (expanded = open)} open={expanded}>
<!-- Rendered as a menu item so arrow keys, typeahead and Enter reach it, but
through the `child` snippet to keep Collapsible.Trigger's native button.
closeOnSelect keeps the menu open while the effort list is being used. -->
<!-- A menu item (for keyboard nav) rendering Collapsible.Trigger via `child`;
closeOnSelect keeps the menu open while picking. -->
<DropdownMenu.Item
class="w-full min-w-0 cursor-pointer items-center gap-2 rounded-md text-left text-sm"
closeOnSelect={false}
>
{#snippet child({ props })}
<!-- No `class` here on purpose: a static attribute would override the
spread props.class, and the button is the menu item itself (the `child`
snippet replaces Item's own div), so all styling must come from above. -->
<!-- No `class` here: a static attribute would override the spread props.class. -->
<Collapsible.Trigger {...props}>
{#if reasoning.isReasoningActive}
<Lightbulb class="{ICON_CLASS_DEFAULT} shrink-0 text-amber-400" />
@@ -54,13 +49,9 @@
</DropdownMenu.Item>
<Collapsible.Content>
<!-- Collapsible.Content only toggles the `hidden` attribute, so gate on
`expanded`: collapsed, the effort rows leave both the menu item order
(bits-ui collects items by attribute) and the tab order. -->
<!-- Gate on `expanded` so collapsed rows leave the menu item and tab order. -->
{#if expanded}
<!-- Plain items, not a RadioGroup: the selected effort lives in the store,
so the check mark derives from it and must not be duplicated as group
state. -->
<!-- Plain items (not a RadioGroup): selection lives in the store. -->
<div class="mt-0.5 flex flex-col gap-0.5 pl-4">
{#each reasoning.levels as level (level.value)}
{@const tokenLabel = reasoning.tokenLabel(level)}
@@ -46,9 +46,6 @@
let hasTools = $derived(detectToolUseSupport(gguf?.chat_template ?? ''));
let hasReasoning = $derived(detectThinkingSupport(gguf?.chat_template ?? ''));
// Draft sidecars (mtp, dflash, dspark, eagle3) present in the repo, e.g.
// speculative-decoding drafts. mmproj is excluded: it is vision.
let bitDepthRows = $derived.by<BitDepthRow[]>(() => {
const rows = new SvelteMap<number, HfModelSibling[]>();
+6 -17
View File
@@ -26,33 +26,24 @@ export interface ModelOption {
tags?: string[];
}
/**
* Ephemeral UI-only load progress for one model instance.
* Lives only while a load runs, driven by the /models/sse feed.
* stage is absent until the feed reports its first stage.
*/
/** UI-only load progress for one model, driven by the /models/sse feed. */
export interface ModelLoadProgress {
stages: ApiModelLoadStage[];
current: ApiModelLoadStage;
value: number;
}
/**
* Per-byte download progress for one in-flight model download, driven by the
* /models/sse feed. Lives only while a download runs.
*/
/** Per-file bytes of an in-flight download. */
export interface ModelDownloadFileProgress {
/** Bytes downloaded for this file so far. */
done: number;
/** Total bytes of the file. */
total: number;
}
/** Progress of an in-flight download, summed across its files. */
export interface ModelDownloadProgress {
/** Summed progress across all files of the download plan. */
downloadedBytes: number;
/** Summed plan size across all files. */
totalBytes: number;
/** Per-file progress keyed by file URL, as reported by the feed. */
/** Per-file progress keyed by file URL. */
files: Record<string, ModelDownloadFileProgress>;
}
@@ -68,9 +59,7 @@ export interface ParsedModelId {
tags: string[];
}
/**
* Modality capabilities for file validation
*/
/** Modality capabilities for file validation. */
export interface ModalityCapabilities {
hasVision: boolean;
hasAudio: boolean;